Use all-the-package-repos as a source of package names #26
+2,412
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
What @jimaek said :)
Please @-message me again if I'm blocking you on anything! 💛 |
This was referenced Feb 7, 2022
Closed
Closed
|
Nice work, @zarianec 🙌🏼 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows the discussion in this issue and changes the way names list is built.
Since all-the-package-repos package now contains all the packages even if they don't have a repo, it is used to build a separate package names list without need to maintain another NPM changes feed reader.
Caveat of this solution is that now package names are not sorted by dependants.
Both dependent-counts and dependent-packages seems to be broken and doesn't contain valid information at the moment.
resolve #24
resolve #25